Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding a reply event to another room will leak the reply text, and via servers #14824

Closed
Half-Shot opened this issue Jul 30, 2020 · 4 comments
Labels

Comments

@Half-Shot
Copy link
Member

If the participants of room B are not in room A, they will still see the replied to sender, body and via servers in the event source. It's not particularly sporting of Element to do this as the UI just shows a Unable to load event that was replied to, it either does not exist or you do not have permission to view it..

In this case it's particularly annoying because some of the via servers should probably have remained private...

@t3chguy
Copy link
Member

t3chguy commented Jul 30, 2020

It is just following the spec? Shouldn't this be in matrix-doc?

https://matrix.org/docs/spec/client_server/r0.6.1#fallbacks-and-event-representation

@Half-Shot
Copy link
Member Author

Well, it's still a leak so I'd like to document the unsafe nature of the feature in here regardless, but we should probably open something on matrix-doc too.

I should mention that the spec doesn't require ?via= on the reply format, so stripping those would still compliant with the spec.

@Half-Shot
Copy link
Member Author

Hmm, thinking about it a bit more...

I don't think the spec mandates that you are required to keep the reply format at all when handling forwarded messages, since the spec doesn't describe event forwarding at all (yet). Presumably even just forwarding the reply content to a room would be safer than what we have today.

@turt2live
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants