Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previewing a room adds it to the 'historical' section of the roomlist. #10861

Closed
lampholder opened this issue Sep 13, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3445
Closed

Previewing a room adds it to the 'historical' section of the roomlist. #10861

lampholder opened this issue Sep 13, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3445
Assignees
@t3chguy
Labels
P1 T-Defect X-Regression

Comments

@lampholder
Copy link
Member

lampholder commented Sep 13, 2019 •
edited
Loading

Riot Web 1.3.5-rc.1

To reproduce:

  • open the room directory
  • preview a room
  • observe that, if you didn't have a historical section in your room list, you do now
    • on my first attempt, the historical section had a room-sized gap instead of the room
    • switching to a different room rendered the historical section with the previewed room in it
    • previewing subsequent rooms added them to the historical section without the gappiness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
P1 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only put a room in Historical if === 'leave' not peeked matrix-org/matrix-react-sdk
2 participants
@lampholder @t3chguy