Merge pull request #16292 from vector-im/t3chguy/sso_fixes

t3chguy · web-flow · commit d5a824d6dd2a · 2021-01-29T13:29:02.000Z
Use history replaceState instead of redirect for SSO flow
diff --git a/src/vector/app.tsx b/src/vector/app.tsx
@@ -124,7 +124,7 @@ function onTokenLoginCompleted() {
     parsedUrl.search = "";
     const formatted = url.format(parsedUrl);
     console.log(`Redirecting to ${formatted} to drop loginToken from queryparams`);
-    window.location.href = formatted;
+    window.history.replaceState(null, "", formatted);
 }
 
 export async function loadApp(fragParams: {}) {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ function onTokenLoginCompleted() {`
`124`	`124`	`parsedUrl.search = "";`
`125`	`125`	`const formatted = url.format(parsedUrl);`
`126`	`126`	console.log(`Redirecting to ${formatted} to drop loginToken from queryparams`);
`127`		`- window.location.href = formatted;`
	`127`	`+ window.history.replaceState(null, "", formatted);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`export async function loadApp(fragParams: {}) {`