Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Render heroes avatar when a room has no avatar #2451

Open
6 tasks
bmarty opened this issue Jun 20, 2024 · 0 comments
Open
6 tasks

[Story] Render heroes avatar when a room has no avatar #2451

bmarty opened this issue Jun 20, 2024 · 0 comments

Comments

@bmarty
Copy link
Member

bmarty commented Jun 20, 2024

Description

  • As a user I want to see avatar of heroes when a room does not have avatar so that it can give more information to distinguish rooms.

Acceptance criteria

  • Avatar for rooms with 1, 2, 3 and 4 heroes are correctly rendered:
    • in the room list
    • in the room timeline header
    • in the room detail screen

Design: https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=1474-886&t=Aw5gIQI0PSBCqERx-1

image

Note: implementation has been started on Android in element-hq/element-x-android#3058, so it's just a matter of removing some code (elementHeroes) and maybe iterate on design for the case 2 heroes (to be confirmed with @amshakal)

Current rendering on Android, for the case 2, 3 an d4 heroes:

image

A is the first hero, B the second, C the third and D the fourth.

Other Android screenshots:

image

Leads

Size estimate

M

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

No tasks being tracked yet.

Subtasks

Android

No tasks being tracked yet.

iOS

No tasks being tracked yet.

Rust

No tasks being tracked yet.

Other

No tasks being tracked yet.

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant