Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room upgrade to room with different settings #1373

Open
benparsons opened this issue Feb 16, 2021 · 4 comments
Open

Room upgrade to room with different settings #1373

benparsons opened this issue Feb 16, 2021 · 4 comments

Comments

@benparsons
Copy link
Member

Is your suggestion related to a problem? Please describe.
I have a room which is encrypted, and contains several users who are less comfortable with technology. I need to upgrade the room, and would like to be able to send an upgrade notice. However, the room population has grown, and I would prefer for my new room to no longer use e2e.

Describe the solution you'd like
When I perform /upgraderoom x, an additional, optional flag to make different settings in the new room, specifically encryption.

Describe alternatives you've considered
I could craft my own tombstone event and use that, per https://matrix.org/docs/spec/client_server/latest#m-room-tombstone.

@t3chguy
Copy link
Member

t3chguy commented Feb 16, 2021

/upgraderoom x is just a wrapper around https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-rooms-roomid-upgrade with optional inviting. Having additional code to manually handle room upgrade emission seems a bit duplicative and strange and will likely fall out of sync with the spec whenever the list of events to copy ever changes causing mismatched behaviour depending on which client you use to upgrade a room

@pilot51
Copy link

pilot51 commented Nov 19, 2021

I recently upgraded an unencrypted room on my homeserver and the new room had encryption. There was no warning about that in the upgrade dialog and I didn't want it because I was planning to add a bridge to the room, which wouldn't work properly with encryption. I had to create a whole new room to disable encryption again.

The option to choose whether the upgraded room has encryption would be ideal, but absent that, all of the settings from the old room should be carried over including encryption.

@t3chguy
Copy link
Member

t3chguy commented Nov 19, 2021

@pilot51 as above, all of the upgrade behaviour is handled by the server, not Element Web.
Element just called the upgrade API https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-rooms-roomid-upgrade

@pilot51
Copy link

pilot51 commented Nov 20, 2021

@t3chguy Sorry, I must have been too tired and/or rushed to comprehend what I was reading and posted anyway because I just wanted to vent. I should have slept on it.

Here's the issue for Synapse: matrix-org/synapse#9246

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants