Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC3987: Push actions clean-up #7585

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Jun 7, 2023

This PR implements the change requested by #7576 by adding support for MSC3987 which deprecates the dont_notify action for a push_rule.

@nimau nimau requested a review from stefanceriu June 7, 2023 09:42
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (3e30eaf) 12.36% compared to head (12159cc) 12.21%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7585      +/-   ##
===========================================
- Coverage    12.36%   12.21%   -0.15%     
===========================================
  Files         1648     1648              
  Lines       163634   163663      +29     
  Branches     67192    67195       +3     
===========================================
- Hits         20232    19992     -240     
- Misses      142737   143026     +289     
+ Partials       665      645      -20     
Flag Coverage Δ
uitests 55.05% <ø> (ø)
unittests 6.06% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Riot/Categories/MXRoom+Riot.m 0.00% <0.00%> (ø)
.../MatrixSDK/MXRoomNotificationSettingsService.swift 0.00% <0.00%> (ø)
...tions/Model/MatrixSDK/MXNotificationPushRule.swift 0.00% <0.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nimau nimau merged commit b7d008d into develop Jun 7, 2023
@nimau nimau deleted the nimau/7576_msc3987_push_actions_cleanup branch June 7, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants