Threads: When read, doesn't leave Unreads filter view

[daniellekirkwood]

I got a thread message in a room, once I read it and went to the Unreads tab the message is read but the room shows in the Unreads tab still

[toshanmugaraj]

At random cases the fetcher predicate fetches data with s_hasAnyUnread:false even when the predicate has MXRoomSummaryDataTypesUnread

[alfogrillo]

At random cases the fetcher predicate fetches data with s_hasAnyUnread:false even when the predicate has MXRoomSummaryDataTypesUnread

I think it was because s_hasAnyUnread wasn't really used for this kind of fetch (very counterintuitively).
Now it should after this.
Please have look if you wish!

[Johennes]

Reopening as the original fix was reverted in matrix-org/matrix-ios-sdk#1736.

[NicolasBuquet]

I don't understand why matrix-org/matrix-ios-sdk#1723 was reverted by matrix-org/matrix-ios-sdk#1736 ?

Unread tabs list a lot of totally read rooms.

If i locally reapply matrix-org/matrix-ios-sdk#1723 then unread tab only lists rooms with unread messages as attended.

Please, reapply matrix-org/matrix-ios-sdk#1723

[pixlwave]

If I remember correctly, whilst the mentioned PR did fix the underlying bug, it completely changed the desired behaviour of the tab, which is to only show rooms with notifications, and not simply any room where the read marker isn't on the last event. This is why the bug still stands, it will need to be fixed some other way.

[alfogrillo]

@NicolasBuquet I have the same memories as Doug.
Unintuitively although the tab says "Unreads", people expect to see rooms with notifications there.
This is why we decided to revert that PR.

[NicolasBuquet]

Thank you for your comments.

But to have a better understanding, what is the difference between a room with unread messages and a room with notifications?

And, won't it be a good thing finally to be able to parametrize this filter on the Matrix SDK side?

[pixlwave]

If you set a room's notification settings to Mentions and Keywords only, then it will have an unread message for you when someone sends a message of Hello world, but when someone mentions @NicolasBuquet in a message, then it will have a notification. In practice the app:

• Shows no indicator for a read room
• Shows a black indicator on the leading edge of the cell for an unread room
• Shows a number on the trailing edge of the cell for a room with a notification.

[NicolasBuquet]

@pixlwave Thank you for this explanation.

It's clearer for me now. 🙏