Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing room summary last messages slows down the initial sync #6240

Open
manuroe opened this issue Jun 3, 2022 · 0 comments
Open
Assignees
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@manuroe
Copy link
Member

manuroe commented Jun 3, 2022

Steps to reproduce

After this PR, last year, an initial sync required 467 decryptions on a 600 room account, using 2.8s of an iPhoneX CPU.

1.8.17 requires now 4643 decryptions for a 850 room account. They use 120s of iPhone 13 CPU before this fix for #6239 (Maybe 25s now).

But we are still comparing 2.8s of iPhoneX with 25s of iPhone 13.

The change comes from matrix-org/matrix-ios-sdk@1f9d638?diff=split&w=1 that transforms the lazy fix of room summaries by a mandatory step.

This step is expansive. It fetches (and decrypts) 50 messages per problematic rooms.

Outcome

Reduce the number of required decryptions during an initial sync.

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@manuroe manuroe added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jun 3, 2022
@stefanceriu stefanceriu added A-E2EE S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants