Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find a way to compose common implementation of the RoomViewControllerDelegate between RoomCoordinator and ExploreRoomCoordinator #5710

Open
gileluard opened this issue Feb 28, 2022 · 0 comments
Open

Find a way to compose common implementation of the RoomViewControllerDelegate between RoomCoordinator and ExploreRoomCoordinator #5710

gileluard opened this issue Feb 28, 2022 · 0 comments
Labels
A-Room T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@gileluard
Copy link
Contributor

Your use case

RoomCoordinator and ExploreRoomCoordinator are both RoomViewControllerDelegate with a large amount of common code. The idea would be to extract common code into independent modules that could be used by both coordinators.

Have you considered any alternatives?

No response

Additional context

No response
@gileluard gileluard added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 28, 2022
@gileluard gileluard mentioned this issue Feb 28, 2022
Merged
@Anderas Anderas added the A-Room label Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Anderas @gileluard