Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads: Improve fallback for clients without Threads #5394

Closed
Tracked by #9
daniellekirkwood opened this issue Jan 18, 2022 · 4 comments
Closed
Tracked by #9

Threads: Improve fallback for clients without Threads #5394

daniellekirkwood opened this issue Jan 18, 2022 · 4 comments
Assignees
Labels
A-Threads Message threading to simplify the Timeline Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Jan 18, 2022

Your use case

Instead of including the Root Message in the Reply view for clients without Threads, show the message previous to the response.

@daniellekirkwood to add more info

We know and accept that some clients will not update their versions and therefore will not have this new and improved fallback will not be available to everyone. Those users who do not update their version from the app/play store will still have the previous fallback of seeing the Root message.

@daniellekirkwood daniellekirkwood added A-Threads Message threading to simplify the Timeline Z-ThreadsP0 The first milestone for Threads labels Jan 18, 2022
@daniellekirkwood
Copy link
Contributor Author

This was raised in testing on January 22, 2022 as a "fail" and I suspect that's because the work is not yet complete (and wasn't ready for testing). Can you confirm that please, @ismailgulek

@daniellekirkwood daniellekirkwood added the Z-ThreadsInternalTesting Issue found while testing Threads internally label Jan 25, 2022
@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Jan 25, 2022

I think we also need content for what to show when the message has not yet been fetched, as we're currently showing "null". This also is the case on Android: element-hq/element-android#4972

@janogarcia

@daniellekirkwood
Copy link
Contributor Author

From Aris:

This case would be rare while now we are using as fallback the previous event. However, I implemented that. You can suggest a better text resource:
https://user-images.githubusercontent.com/60798129/151002008-bcaa5ac9-677a-49ff-a9e7-7c1f979436fb.jpg

@janogarcia
Copy link

@daniellekirkwood As discussed for Android, I'd suggest changing the placeholder message copy to In reply to a thread if we're not rendering the In reply to @name part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads Message threading to simplify the Timeline Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads
Projects
None yet
Development

No branches or pull requests

3 participants