Build, Sign & Notarise macOS builds #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
had a problem deploying
to
packages.element.io
GitHub Actions
Failure
andybalaam
reviewed
Jan 17, 2023
andybalaam
approved these changes
Jan 17, 2023
40 tasks
t3chguy
temporarily deployed
to
packages.element.io
GitHub Actions
Inactive
t3chguy
had a problem deploying
to
packages.element.io
GitHub Actions
Failure
t3chguy
temporarily deployed
to
packages.element.io
GitHub Actions
Inactive
t3chguy
had a problem deploying
to
packages.element.io
GitHub Actions
Failure
t3chguy
temporarily deployed
to
packages.element.io
GitHub Actions
Inactive
t3chguy
temporarily deployed
to
packages.element.io
GitHub Actions
Inactive
t3chguy
temporarily deployed
to
packages.element.io
GitHub Actions
Inactive
andybalaam
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://til.simonwillison.net/electron/sign-notarize-electron-macos has been an invaluable resource here
Unfortunately notarisation in GHA seems almighty slow.
On the dedicated mac mini the whole build takes ~10 mins, about 3.5x faster and that is without the hak caching we do here.
This change is marked as an internal change (Task), so will not be included in the changelog.