Use device labels rather than IDs in widget API #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
device IDs are different for each origin, so won't match up when passed in & out of widgets. Use the label instead. For element-hq/element-web#23331
dbkr
added
the
T-Defect
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Sep 27, 2022
3 tasks
As per comment.
robintown
reviewed
Sep 29, 2022
Because lots of audio & video inputs have the same name
robintown
approved these changes
Sep 30, 2022
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Sep 30, 2022
…9321) * Fix device selection in pre-join screen for Element Call video rooms As per element-hq/element-call#609 * Update unit test * Lint * Hold a media stream while we enumerate device so we can do so reliably. This means we can remove the device fallback labels. * i18n * Remove unnecessary useState * Fix fetching video devices when video muted * Actually fix preview stream code * Fix unit test now fallback is no longer a thing * Test changing devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device IDs are different for each origin, so won't match up when passed in & out of widgets. Use the label instead.
For element-hq/element-web#23331