Skip to content

Restrict importing src/lib in most cases for matrix- libs #3575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

Restrict importing src/lib in most cases for matrix- libs #3575

merged 1 commit into from
Nov 20, 2025

Conversation

@Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Nov 20, 2025

Based off @BillCarsonFr 's struggles, we can use the linter to prevent us importing /paths, which is usually a bad smell.

@Half-Shot Half-Shot requested a review from a team as a code owner November 20, 2025 13:33
@Half-Shot Half-Shot requested a review from AndrewFerr November 20, 2025 13:33
@Half-Shot Half-Shot added T-Task Refactoring, enabling or disabling functionality, other engineering tasks PR-Task Release note category. A PR that is hidden from release note. PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. and removed T-Task Refactoring, enabling or disabling functionality, other engineering tasks PR-Task Release note category. A PR that is hidden from release note. labels Nov 20, 2025
BillCarsonFr
BillCarsonFr approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly, thx

toger5
toger5 approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@toger5 toger5 merged commit f6ef872 into livekit Nov 20, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@toger5 toger5 toger5 approved these changes

@AndrewFerr AndrewFerr Awaiting requested review from AndrewFerr AndrewFerr is a code owner automatically assigned from element-hq/element-call-reviewers

Assignees

No one assigned

Labels

PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Half-Shot @BillCarsonFr @toger5