Don't fall back as eagerly to unselected devices #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere around version 131 or 132, Firefox has started being more paranoid about media device fingerprinting, and will not even give you the IDs of available devices until you've requested a media stream. Instead you only get a single audio input and video input each with the empty string as their device ID, representing the system's default device. We can recognize this case and avoid resetting the device selection.
toger5
reviewed
Nov 20, 2024
src/livekit/MediaDevicesContext.tsx
Outdated
Comment on lines
96
to
102
| // Otherwise, fall back to the first available device. | ||
| devId = | ||
| available.some((d) => d.deviceId === selectedId) || | ||
| available.every((d) => d.deviceId === "") | ||
| ? selectedId | ||
| : available.at(0)?.deviceId; | ||
| } |
There was a problem hiding this comment.
Where is the fallback happening?
If all devices are "" we would still end up using selectedId. What if that is not available? If the browser is paranoid but also the mic has been disconnected?
Where do we catch that?
toger5
reviewed
Nov 21, 2024
Comment on lines
+96
to
+98
| // Worst case it is not available and the browser will gracefully fall | ||
| // back to some other device for us when requesting the media stream. | ||
| // Otherwise, select the first available device. |
toger5
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere around version 131 or 132, Firefox has started being more paranoid about media device fingerprinting, and will not even give you the IDs of available devices until you've requested a media stream. Instead you only get a single audio input and video input each with the empty string as their device ID, representing the system's default device. We can recognize this case and avoid resetting the device selection.
Closes #2770