Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several slightly different loading screens #461

Open
dbkr opened this issue Jul 8, 2022 · 7 comments
Open

Several slightly different loading screens #461

dbkr opened this issue Jul 8, 2022 · 7 comments
Labels
good first issue Good for newcomers Help Wanted O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@dbkr
Copy link
Member

dbkr commented Jul 8, 2022

Steps to reproduce

It looks like there are several screens that say "Loading..." in slightly different ways, between LoadingView and others views that just return <h1>Loading...</h1> (eg. RegisteredView, UnauthenticatedView). As a walkie-talkie call loads, I can see it step through two different versions of "Loading..." with a slightly different size font (and then "Loading room...").

Outcome

What did you expect?

Probably just one "Loading...", or one saying, "Reticulating splines..."

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

@dbkr dbkr added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 8, 2022
@robintown robintown added the X-Needs-Design May require input from the design team label Jul 11, 2022
@robintown
Copy link
Member

Gaëlle says yes, we should change all loading screens to simply say "Loading…"

@robintown robintown added good first issue Good for newcomers Help Wanted and removed X-Needs-Design May require input from the design team labels Nov 17, 2022
@abhijain2003
Copy link

can I work on this. yes having consistency on the loading screen is quite important.

@SimonBrandner
Copy link
Contributor

can I work on this. yes having consistency on the loading screen is quite important.

Yes, sure, good luck!

@abhijain2003
Copy link

Thanks

@abhijain2003
Copy link

abhijain2003 commented Feb 8, 2023

I just changed Loading room... to Loading... from
GroupCallView.tsx and GroupCallLoader.tsx and in all public/locales/[file]/app.json I just removed key-value of
"Loading room...": "Loading room...". As I think these are all implementation of multiple language support and as we are not using Loading room... anywhere I thought removing these properties from public/locales/[file]/app.json would be best.

while some other files still using slightly different words for loading in different components

such as Saving... is used like this in ProfileModal.tsx

{loading ? t("Saving…") : t("Save")}

and some are using Sending... I didn't change them to Loading.... as I thought they are matching with CTA
but if you want I will also change them.

so anyone please help me on these queries.
it would be helpful in my initial contributions

@SimonBrandner
Copy link
Contributor

... and in all public/locales/[file]/app.json I just removed key-value of "Loading room...": "Loading room...". As I think these are all implementation of multiple language support and as we are not using Loading room... anywhere I thought removing these properties from public/locales/[file]/app.json would be best.

You aren't supposed to touch those files by hand. Remove the changes there and run yarn i18n which should update the appropriate files, rest is handled by Weblate

@abhijain2003
Copy link

ok I understood, I will make relative changes

Thanks for letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Help Wanted O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
No open projects
Development

No branches or pull requests

4 participants