Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No audio on screenshare after doing no-audio screenshare #1032

Open
dbkr opened this issue Apr 28, 2023 · 2 comments
Open

No audio on screenshare after doing no-audio screenshare #1032

dbkr opened this issue Apr 28, 2023 · 2 comments
Labels
A-Screenshare O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@dbkr
Copy link
Member

dbkr commented Apr 28, 2023

Steps to reproduce

  1. Join call with at least 2 users
  2. Start a screenshare from a source with no audio (eg. desktop window on macOS)
  3. End the screenshare
  4. Start screenshare with audio (eg. chrome tab on macOS)

Outcome

What did you expect?

Noise

What happened instead?

Audio from the screenshare doesn't get through

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

Yes

@dbkr dbkr added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Apr 28, 2023
@robintown robintown added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Screenshare labels Apr 28, 2023
@robintown
Copy link
Member

This is hypothesized to be because it reuses the screenshare transceiver that didn't have an audio track

@SimonBrandner
Copy link
Contributor

This is hypothesized to be because it reuses the screenshare transceiver that didn't have an audio track

Sort of, the problem is that we re-use the video transceiver but not the audio transceiver (since we have none). This results in two transceivers with different stream IDs since the video one uses the old stream ID and the audio one uses the stream ID of the new stream.

One of the signs this is the case are the following logs:

2023-05-05T18:12:00.854Z I Call 1683308472810TfJDwFkrRdeJ3sSc pushRemoteFeed() pushed stream (streamId=57e542c3-e336-46ef-bf03-590def025ca4, active=true, purpose=m.screenshare)
2023-05-05T18:12:00.854Z I Call 1683308472810TfJDwFkrRdeJ3sSc pushRemoteFeed() pushed stream (streamId=48f7485b-dcd1-421d-a72c-e4c571b94fe6, active=true, purpose=m.screenshare)
2023-05-05T18:12:00.859Z I useMediaStream update stream mediaRef.current true stream 57e542c3-e336-46ef-bf03-590def025ca4 muted false
2023-05-05T18:12:00.868Z I useMediaStream update stream mediaRef.current true stream 57e542c3-e336-46ef-bf03-590def025ca4 muted true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Screenshare O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
No open projects
Development

No branches or pull requests

3 participants