Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickable URL in Code Block #8177

Open
dzlandis opened this issue Feb 25, 2023 · 2 comments
Open

Clickable URL in Code Block #8177

dzlandis opened this issue Feb 25, 2023 · 2 comments
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@dzlandis
Copy link

dzlandis commented Feb 25, 2023

Steps to reproduce

  1. Send a message containing a URL inside a code block (with markdown that can be done with the ` character on both ends, with html you can use <code></code>), displays like this:
    https://element.io

  2. Observe that the link is clickable despite it being inside the code block.

  3. Optionally observe that this is not the same behavior observed on Element Web

Element Android:
Screenshot_20230225_030849_Element

Element Web:
LJDKSHuc8v

Outcome

What did you expect?

Links in code blocks to not be clickable

What happened instead?

The link can be clicked despite being in a code block

Your phone model

Samsung S22

Operating system version

Android 13

Application version and app store

Element version 1.5.25, olm version 3.2.12 from Play Store

Homeserver

Irrelevant (matrix.org)

Will you send logs?

Yes

Are you willing to provide a PR?

No

@dzlandis dzlandis added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 25, 2023
@dzlandis
Copy link
Author

dzlandis commented Feb 25, 2023

Same issue in element-web which has since been resolved: element-hq/element-web#9613

Also see: matrix-org/matrix-react-sdk#7859

@Florian14 Florian14 added A-Composer S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 27, 2023
@Florian14
Copy link
Contributor

Thanks for raising this issue, this should be solved within an incoming version of the rich text editor, which is currently available in the lab settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants