Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing Integration Manager API actions #7893

Open
justinbot opened this issue Jan 4, 2023 · 2 comments
Open

Implement missing Integration Manager API actions #7893

justinbot opened this issue Jan 4, 2023 · 2 comments
Labels
A-Integrations S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-ElementX Issues which will be resolved by ElementX X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@justinbot
Copy link

justinbot commented Jan 4, 2023

Your use case

What would you like to do?

Add support for these missing Integration Manager postmessage API actions in order to have parity with matrix-react-sdk:

Why would you like to do it?

In order to support new integration manager functionality.

How would you like to achieve it?

Add these actions to the existing Integration Manager postmessage API implementation:
https://github.com/vector-im/element-android/blob/8238cd7f57de936677e72798badef99135116a59/vector/src/main/java/im/vector/app/features/widgets/WidgetPostAPIHandler.kt#L45-L49

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@justinbot justinbot added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Integrations labels Jan 4, 2023
@ganfra
Copy link
Member

ganfra commented Feb 15, 2023

As we are going to move to ElementX, maybe it could be integrated to the matrix-rust-sdk at some point instead?

@ganfra ganfra added X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Needs-ElementX Issues which will be resolved by ElementX labels Feb 15, 2023
@justinbot
Copy link
Author

For Element X integration managers should use the Widget API instead: element-hq/element-meta#792

The idea here is that in the meantime, we could maintain integration manager support with these relatively minor additions to the old Integration Manager postmessage API

@Florian14 Florian14 added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Integrations S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-ElementX Issues which will be resolved by ElementX X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Development

No branches or pull requests

3 participants