Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve full screen mode for Rich Text Editor #7577

Closed
jmartinesp opened this issue Nov 14, 2022 · 0 comments · Fixed by #7578
Closed

Improve full screen mode for Rich Text Editor #7577

jmartinesp opened this issue Nov 14, 2022 · 0 comments · Fixed by #7578
Assignees
@jmartinesp
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jmartinesp
Copy link
Member

Your use case

What would you like to do?

Improve the UI and UX of the full screen mode for the Rich Text Editor.

Why would you like to do it?

The current implementation was provisional, as we had a tight deadline on delivering it. However, it does not match the designs and added unneeded complexity to TimelineFragment and RichTextComposerLayout, now having several constraint sets for the same layout.

How would you like to achieve it?

Use a custom BottomSheetBehavior implementation that resizes its contents and implementing missing designs.

Have you considered any alternatives?

  1. Creating a custom component not depending on CoordinatorLayout. This might make the implementation simpler at the cost at making it more difficult to re-use.
  2. Keep using the current approach with constraint sets and applying new designs. However, the extra complexity of maintaining several layouts is still there.

Additional context

No response

Are you willing to provide a PR?

Yes
@jmartinesp jmartinesp added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor labels Nov 14, 2022
@jmartinesp jmartinesp self-assigned this Nov 14, 2022
This was referenced Nov 14, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New RTE full screen implementation with BottomSheet element-hq/element-android
1 participant
@jmartinesp