Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when returning to app after closing during email verification #6860

Closed
ouchadam opened this issue Aug 17, 2022 · 0 comments · Fixed by #6862
Closed

Crash when returning to app after closing during email verification #6860

ouchadam opened this issue Aug 17, 2022 · 0 comments · Fixed by #6862
Assignees
Labels
A-Onboarding O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience

Comments

@ouchadam
Copy link
Contributor

ouchadam commented Aug 17, 2022

Steps to reproduce

  1. Start the account creation process
  2. When asked to confirm the email, force close the app
  3. Relaunch the app and notice the email verification screen has opened
  4. Continue the account creation process by clicking the link in the email
  5. Notice the app crashes

Outcome

What did you expect?

If the app has been force stopped or crashes during account creation we should reset the flow back to the beginning as it means we've lost track of all the onboarding previous steps. The app is able to correctly restore the registration when the system uses its restoration mechanism (task switching)

What happened instead?

The app shortcuts to the email verification screen without the data from the previous steps, causing the continuation of the account creation to crash due to missing information

https://play.google.com/console/u/0/developers/{redacted}/app/{redacted}/vitals/crashes/f5810fcdfd8bccf4e8c6ec5970ff51ad/details?installedFrom=PLAY_STORE&days=30&clustering=NEW

Thread: main, Exception: java.lang.IllegalStateException: missing url of homeserver
Exception java.lang.IllegalStateException:
  at im.vector.app.features.onboarding.ftueauth.CaptchaWebview.setupWebView (CaptchaWebview.kt:9)
  at im.vector.app.features.onboarding.ftueauth.FtueAuthCaptchaFragment.updateWithState (FtueAuthCaptchaFragment.kt:2)
  at im.vector.app.features.onboarding.ftueauth.AbstractFtueAuthFragment$invalidate$1.invoke (AbstractFtueAuthFragment.kt:3)
  at im.vector.app.features.onboarding.ftueauth.AbstractFtueAuthFragment$invalidate$1.invoke (AbstractFtueAuthFragment.kt:1)
  at androidx.biometric.R$layout.withState
  at im.vector.app.features.onboarding.ftueauth.AbstractFtueAuthFragment.invalidate (AbstractFtueAuthFragment.kt:1)
  at com.airbnb.mvrx.MavericksViewKt$$ExternalSyntheticLambda0.handleMessage (R8$$SyntheticClass:4)
  at android.os.Handler.dispatchMessage (Handler.java:102)
  at android.os.Looper.loop (Looper.java:201)
  at android.app.ActivityThread.main (ActivityThread.java:6861)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:547)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:873)

Your phone model

No response

Operating system version

No response

Application version and app store

1.4.32

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes

@ouchadam ouchadam added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-FTUE Issue is relevant to the first time use project or experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Onboarding Z-Crash labels Aug 17, 2022
@ouchadam ouchadam self-assigned this Aug 17, 2022
@ouchadam ouchadam mentioned this issue Aug 17, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Onboarding O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Crash Z-FTUE Issue is relevant to the first time use project or experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant