Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addToSpace slash command not working #6844

Closed
chagai95 opened this issue Aug 16, 2022 · 2 comments · Fixed by #6941
Closed

addToSpace slash command not working #6844

chagai95 opened this issue Aug 16, 2022 · 2 comments · Fixed by #6941
Labels
A-Composer A-Slash-Commands O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@chagai95
Copy link
Contributor

Steps to reproduce

  1. Go to a room.
  2. Run /addToSpace command:

image

Outcome

What did you expect?

The room to be added to that space.

What happened instead?

The error appeared

Your phone model

Xiaomi 11

Operating system version

Android 12

Application version and app store

1.4.32

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

Yes
@chagai95 chagai95 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 16, 2022
@ouchadam
Copy link
Contributor

am also able to confirm with a unit test in CommandParserTest

@Test
fun parseAddToSpaceCommand() {
    test("/addToSpace !my-space-id", ParsedCommand.AddToSpace("!my-space-id"))
}

looks like the CommandParser is only expecting 1 segment to the command when it should be 2

@ouchadam ouchadam mentioned this issue Aug 25, 2022
Merged
6 tasks
@ouchadam ouchadam added A-Composer A-Slash-Commands S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 26, 2022
@ouchadam
Copy link
Contributor

fixed in 1.4.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Slash-Commands O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing /joinSpace and /addToSpace commands element-hq/element-android
2 participants
@ouchadam @chagai95