Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room directory does not match on fuzzy strings #4291

Open
kittykat opened this issue Oct 21, 2021 · 6 comments
Open

Room directory does not match on fuzzy strings #4291

kittykat opened this issue Oct 21, 2021 · 6 comments
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-Community-Testing Issues found during the community testing sessions Z-FAB Z-WTF WTF moment: High Impact, Low Effort

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 21, 2021

Steps to reproduce

  1. Join room dialog
  2. Search for "Element testing"
  3. See only one result, which is not "Element community testing"

Intended result and actual result

What did you expect?

Seeing results for close matches (ranked below exact matches)

What happened instead?

Only exact matches are shown

See also #3968

Application version and app store

Element 1.3.4 (RC)

Will you send logs?

No

@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Room-List S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Community-Testing Issues found during the community testing sessions labels Oct 21, 2021
@ganfra
Copy link
Member

ganfra commented Oct 22, 2021

Is this filtering on RoomList or filtering on the RoomDirectory (when wanting to join a room)?
Filtering on RoomDirectory is made server side.

@kittykat
Copy link
Contributor Author

@ganfra room directory

@ouchadam
Copy link
Contributor

just seen

@ganfra room directory

which would mean we can't do this client side

@kittykat kittykat changed the title Room filter does not match on fuzzy strings Room directory does not match on fuzzy strings Oct 25, 2021
@daniellekirkwood daniellekirkwood added the Z-Papercuts Visible. Impactful. Predictable to action. label Jan 10, 2022
@daniellekirkwood daniellekirkwood added S-Minor Impairs non-critical functionality or suitable workarounds exist S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 11, 2022
@ouchadam
Copy link
Contributor

As this requires changes to multiple platforms I'm going to convert from defect to enhancement but upgrade from papercut to a wtf

*searching the element corp space on the web client
2022-01-24T09:48:56,217569257+00:00

@ouchadam ouchadam added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF moment: High Impact, Low Effort and removed T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Papercuts Visible. Impactful. Predictable to action. labels Jan 24, 2022
@daniellekirkwood
Copy link
Contributor

@ouchadam have we concluded that this is server-side? Is there anything we can do on the client side or should we move this to the BE team's repo?

@ouchadam
Copy link
Contributor

ouchadam commented Feb 3, 2022

@daniellekirkwood for the room directory search. yep it's server side but for the conversation filtering it's client side.

Room directory search (server)

Screenshot_20220203_115345 Screenshot_20220203_115357

Conversation filtering (local)

Screenshot_20220203_115239 Screenshot_20220203_115252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Team: Delight Z-Community-Testing Issues found during the community testing sessions Z-FAB Z-WTF WTF moment: High Impact, Low Effort
Projects
None yet
Development

No branches or pull requests

4 participants