Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate on UrlPreview design #4278

Closed
bmarty opened this issue Oct 20, 2021 · 2 comments · Fixed by #4610
Closed

Iterate on UrlPreview design #4278

bmarty opened this issue Oct 20, 2021 · 2 comments · Fixed by #4610
Assignees
@ouchadam @amshakal
Labels
A-URL-Previews T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-UI UX

Comments

@bmarty
Copy link
Member

bmarty commented Oct 20, 2021

Element iOS now supports URL previews, and their rendering is nicer than on Element Android, this is not acceptable (just kidding!)
@bmarty bmarty added Z-UI UX T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-URL-Previews labels Oct 20, 2021
@ouchadam ouchadam added the X-Needs-Design May require input from the design team label Oct 25, 2021
@daniellekirkwood
Copy link
Contributor

urlpreviewsios

Is this an example of the url preview you're referencing?

They are only available on unencrypted rooms in iOS...

@amshakal
Copy link

amshakal commented Nov 2, 2021

I followed the product thinking in iOS and created designs for android.

Here are the proposed designs to show URL with images:
Frame 3694
Frame 3695

Here are the proposed designs to show URL without images:
Frame 3696
Frame 3697

Settings tab to turn preview on and off:
Frame 3693

And finally, here is a link to the figma file:
https://www.figma.com/file/U7Pyaa5Y7V7a1QTcjJyb3k/UrlPreview-design?node-id=1%3A41

@daniellekirkwood daniellekirkwood removed the X-Needs-Design May require input from the design team label Nov 16, 2021
@ouchadam ouchadam self-assigned this Dec 1, 2021
@ouchadam ouchadam mentioned this issue Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ouchadam ouchadam

@amshakal amshakal

Labels
A-URL-Previews T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-UI UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating URL preview design element-hq/element-android
4 participants
@ouchadam @bmarty @amshakal @daniellekirkwood