Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with /spoiler tag show in plaintext in the notification #3477

Open
logburn opened this issue Jun 9, 2021 · 3 comments
Open

Messages with /spoiler tag show in plaintext in the notification #3477

logburn opened this issue Jun 9, 2021 · 3 comments
Labels
A-Notifications A-Spoiler Z-GetYourUpdates Delight - Cycle 3 of Chronic issues

Comments

@logburn
Copy link

logburn commented Jun 9, 2021

Describe the bug

Messages sent with /spoiler text show in plaintext in notification. Text that is specifically sent with the /spoiler flag is sensitive enough to be hidden in the chat and should also be hidden in the notification.

To Reproduce

Steps to reproduce the behavior:

  1. Be sent message beginning with /spoiler tag
  2. Open notifications or view from lock screen
  3. Read the plaintext and ponder why it isn't hidden

Expected behavior

Text that is sensitive enough to be hidden within the chat should also be hidden in the notification.

Screenshots

RFNkreYM0Q

Smartphone (please complete the following information):

  • Device: OnePlus 6T
  • OS: LineageOS 18.1

Additional context

  • 1.1.8 - F-Droid
  • matrix.org
@gabrc52
Copy link

gabrc52 commented Dec 29, 2022

This seems to be present in the latest Element web and release too:

image

And on Element desktop too:

image

@gabrc52
Copy link

gabrc52 commented Dec 29, 2022

Actually, I can't reproduce on mobile. Text is spoilered fine:

image

PR #4426 has been merged and fixes this. Can we close this issue?

@gabrc52
Copy link

gabrc52 commented Dec 29, 2022

Web and desktop issue: element-hq/element-web#12034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Spoiler Z-GetYourUpdates Delight - Cycle 3 of Chronic issues
Projects
None yet
Development

No branches or pull requests

4 participants