Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pill sometimes confused of displayname #1046

Open
eras opened this issue Feb 21, 2020 · 1 comment
Open

Pill sometimes confused of displayname #1046

eras opened this issue Feb 21, 2020 · 1 comment
Labels
A-Pills T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@eras
Copy link

eras commented Feb 21, 2020

RiotX 0.16.0 [40016002] (G-b1923)

Matrix SDK Version 0.0.1 (56677f0)

Setting different displayname per room can sometimes confuse Riot-X what the correct displayname for a particular room is.

RiotX:
Captured from RiotX

Riot Web:
Captured from RiotWeb

The room's displayname is "flux". However, my displayname on another room is "erkki" and I had recently received messages on that room. So it sounds like the displayname is cached per mxid, not per room+mxid.

On a later time I tried to view the same message I got the correct pill "flux".

@bmarty
Copy link
Member

bmarty commented Feb 25, 2020

Yes, pills in the timeline use user data and not room member data (which can differ between rooms)

Ref: https://github.com/vector-im/riotX-android/blob/54f2ac0d8cea552e71b4691a0089c37e9772d9b6/vector/src/main/java/im/vector/riotx/features/html/MxLinkTagHandler.kt#L45

We will improve this in the future

@bmarty bmarty added A-Pills T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Pills T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants