Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to / unification of Floating Menu #308

Open
americanrefugee opened this issue Jan 26, 2024 · 2 comments
Open

Updates to / unification of Floating Menu #308

americanrefugee opened this issue Jan 26, 2024 · 2 comments
Assignees

Comments

@americanrefugee
Copy link
Collaborator

Figma document

Storybook pages

Platform

  • Web

Updates requested

There should just be 1 component with the following variants:

  • Account
  • Nav List
  • Filter List
  • Sort List
  • SM Nav List
  • SM Options List
@robintown
Copy link
Member

Some notes to myself:

The fact that a single menu can contain multiple headers (the sort list example), and these headers can contain arbitrary content (the account example) suggests that I should extract out a separate header component in the implementation. And when the menu header disappears in the bottom sheet version, we can implement this by saying that the menu component has an inherent (optional) header slot.

I need to think a bit harder about how to get keyboard navigation to behave correctly in each of these variants, and what the best way would be to provide shortcut components for creating nav lists and option lists.

@robintown robintown added the P-Web Platform Web label Jan 28, 2024
@americanrefugee
Copy link
Collaborator Author

I also noticed that the margins are incorrect in the current implementation...

  • There should be 8px margin on the left and right of each menu item (currently full width)
  • There should be 8px between the last normal menu item, separator, and destructive menu item
  • There should be 4px between menu items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants