Document a gotcha where linking this package leads to conflicting @types/react copies #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes/react copies I spent a good couple hours today struggling to yarn link this package in a way that wouldn't create type errors in my Element Call checkout, and feel compelled to write down my workaround somewhere that others can find it.
robintown
requested review from
t3chguy and
florianduros
and removed request for
a team
|
Would resolutions not be a better workaround?
|
|
I did try that, yeah, but even with identical versions in node_modules/@types/react and node_modules/@vector-im/compound-web/node_modules/@types/react, I was getting the same set of 182 errors… not sure what to make of that since it somehow works for Element Web |
|
Using resolutions is also not a great solution IMO because it requires you to keep the versions exactly in sync, which is a job that I feel should be left to Yarn to handle automatically. (which it does as long as you don't use linking, and the versions requested are compatible) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a good couple hours today struggling to
yarn linkthis package in a way that wouldn't create type errors in my Element Call checkout, and feel compelled to write down my workaround somewhere that others can find it.