Add in-progress view to EditInPlace component #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the InlineSpinner component so we can use it. Also tweaks a lot of the spacing & sizing of the caption icons in EditInPlace to get them right.
dbkr
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jun 12, 2024
4 tasks
Deploying compound-web with
|
| Latest commit: |
cb6cf8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e4695e08.compound-web.pages.dev |
| Branch Preview URL: | https://dbkr-editinplace-inprogress.compound-web.pages.dev |
t3chguy
requested changes
Jun 12, 2024
playwright/visual.test.ts-snapshots/Form-Controls-EditInPlace-With-Error-1-chromium-linux.png
Show resolved
Hide resolved
playwright/visual.test.ts-snapshots/InlineSpinner-Default-1-chromium-linux.png
Show resolved
Hide resolved
t3chguy
approved these changes
Jun 13, 2024
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jun 14, 2024
* Add in-progress view to display name EditInPlace Requires element-hq/compound-web#180 * Update to new compound-web for editinplace component with spinner * Update snapshots for element-hq/compound-web#178 * Update screenshots * Remove margin which isn't necessary now there's no 'Remove' link on the bottom * Update screenshots
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Jun 14, 2024
* Add in-progress view to display name EditInPlace Requires element-hq/compound-web#180 * Update to new compound-web for editinplace component with spinner * Update snapshots for element-hq/compound-web#178 * Update screenshots * Remove margin which isn't necessary now there's no 'Remove' link on the bottom * Update screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the InlineSpinner component so we can use it. Also tweaks a
lot of the spacing & sizing of the caption icons in EditInPlace
to get them right.
Based on #179