migrate to typescript & node.js-compatible es modules

[zackschuster]

• port to node.js-compatible es modules
• port to typescript
• reconfigure rollup
• fix tests
• point main to either cjs rollup bundle or esm source (prob cjs)

[eleith]

looking good.

i'm also open to seeing this project move to typescript if that helps with big changes like this to prevent regressions.

[zackschuster]

i wouldn't mind doing the port job to typescript. i'd also move the test suite to ava, which i have experience in using with typescript.

[zackschuster]

PR is in typescript now. made a few (relatively) minor API changes (like condensing error codes into a const enum & getting rid of legacy code that said "will remove at some point"), since i'm pretty sure this will end up semver major no matter what.

[eleith]

i wouldn't mind doing the port job to typescript. i'd also move the test suite to ava, which i have experience in using with typescript.

why ava vs jest?

[zackschuster]

technically, they have a pretty similar feature set & both are written with current tools. the breaker for me is that jest is a facebook project, whereas ava is community-led (started by sindresorhus).

[zackschuster]

also it looks like we'd have to install @types/jest, whereas ava has types built-in: https://swizec.com/blog/the-big-mac-index-and-jest-fetch-testing/swizec/9187

(coincidentally i've already tested fetch with ava)

[zackschuster]

esm in node will probably ship unflagged on 12.x in april. i'll try to finish this around then.

[zackschuster]

tests are failing locally due to smtp server issues. image attached for reference:

[zackschuster]

i think the above might be due to changes i made during conversion. i'm going through the shipped code to repair differences.

side note: node 14 today! hooray for unflagged modules! fun fact: the flag warning almost wasn't removed & node's tsc was surprised to see it happen

[zackschuster]

modules are still considered experimental, so i feel less bad about not landing this in time with the launch >D

[eleith]

@zackschuster looking good. i've given you direct access to the project in reflection of your contribution to the project. fyi, a few of the outdated dependencies for emailjs are throwing up security alerts on github for this project, so perhaps those can get addressed during this upgrade.

[zackschuster]

thank you! :D i'll see if i can move the PR from my fork to a local branch without breaking things.

for addressparser, would you like to switch to emailjs-addressparser?

[eleith]

depends on the effort level, if it is transparent, sure.

[zackschuster]

closing in favor of #246