Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D5 :: Add custom fonts to the font family list in the FontHeaderGroup component for headings #98

Open
8 tasks
shohel opened this issue Oct 17, 2024 · 0 comments
Assignees
Labels
bug Something isn't working in progress ET dev team is currently working on it triaged Whether the issue is already triaged or not

Comments

@shohel
Copy link
Collaborator

shohel commented Oct 17, 2024

Problem Description

  1. Describe what you did
    There is no way to override/add fonts in the font-family list for FontHeaderGroup component

Discord - https://discord.com/channels/1041765492907589683/1294325179387875421

  1. Describe what you expected to happen
    I would like to see my custom fonts in the font family list.

  2. Describe what actually happened
    I can't add my own custom fonts. Example below.

<FontHeaderGroup
                    title="Footer Heading Text"
                    attrName="footer.decoration.headingFont"
                    defaultGroupAttr={defaultSettingsAttrs?.footer?.decoration?.headingFont?.asMutable({ deep: true }) ?? {}}
                    fields={{
                        h1: {
                            family:{
                                component: {
                                    type: 'field',
                                    name: 'divi/select-font',
                                    props: {
                                        googleFonts: ['TestFont 1', 'TestFont 2'],
                                    }
                                }
                            }
                        },
                    }}
                />

It should override the google fonts in the font family list.

Detailed Steps To Reproduce

Please provide a detailed list of exact steps that reproduce the issue.
1.
2.
3.

Related Links or Information

If applicable, please provide links to any related issues, PRs, discord discussions, or other information.
Discord Discussion: How to add custom field to a FonHeaderGroup tab

Screenshot and/or gif

Ideally a video screencast or gif of the issue being reproduced. If not, a screenshot of the issue is acceptable and annotating the screenshot with a red circle/arrow and text, as applicable, is helpful.

System Information

  • Divi version: 5.0.0-dev-alpha.1
  • Operating System: macOS 10.15.7
  • Browser: Chrome 87.0.4280.88
  • PHP version: 7.4.12
  • MySQL version: 5.7.32
  • Web Server: Apache
  • WordPress version: 6.1.1

Due Diligence Checklist

  • I searched for similar issues before opening this one
  • I have tested with all plugins deactivated except Elegant Themes Beta Tester
  • I have tested with the latest alpga/beta version of Divi
  • I used a clear and descriptive title
  • I have included a detailed description
  • I have included steps to reproduce
  • I have included relevant links or information
  • I have included a video or gif or screenshot
@shohel shohel added the bug Something isn't working label Oct 17, 2024
@shohel shohel self-assigned this Oct 17, 2024
@shohel shohel added triaged Whether the issue is already triaged or not in progress ET dev team is currently working on it labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress ET dev team is currently working on it triaged Whether the issue is already triaged or not
Projects
None yet
Development

No branches or pull requests

1 participant