This repository was archived by the owner on Mar 4, 2020. It is now read-only.
refactor: split out main config so inspector can share #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
force-pushed
the
unify-config
branch
from
af19f85 to
f66263f
Compare
hashseed
reviewed
Feb 5, 2019
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
nitsakh
pushed a commit
that referenced
this pull request
Mar 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91.
This reduces the likelihood that inspector could be assuming a different memory layout of Node data structures due to varying build flags.