Skip to content

MakerDMG config requiring appPath even thought it is never used in typescript project #3712

Open

Description

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

7.5.0

Electron version

v32.1.1

Operating system

macOS 15.1 Beta (24B5046f)

Last known working Electron Forge version

7.4.0

Expected behavior

Being able to create a DMG installer without having to specify a fake appPath in config needing to satisfy type check.

Actual behavior

Additional config property appPath being needed to add to the config to satisfy type check. This appPath is never used for anything other than to satisfy the type check as appPath is always overridden in the make method.

appPath: path.resolve(dir, `${appName}.app`),

Steps to reproduce

  1. Add @electron-forge/maker-dmg@7.5.0 to package.json in a typescript forge project.
  2. Add MakerDMG to forge.config.ts with empty config object, typescript will complain about appPath not being present.

Additional information

875ee54 upgraded electron-installer-dmg from 4.0.0 to 5.0.1.

MakerDMGConfig was modified to extend ElectronInstallerDMGOptions from electron-installer-dmg, which requires appPath by default to be included in the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions