Skip to content

feat: add skip feature for bisection#1690

Merged
dsanders11 merged 1 commit into
electron:mainfrom
chan95821:bisect-skip
Jul 23, 2025
Merged

feat: add skip feature for bisection#1690
dsanders11 merged 1 commit into
electron:mainfrom
chan95821:bisect-skip

Conversation

@chan95821

Copy link
Copy Markdown
Contributor

Bias was set to better choose an appropriate version to test based on the skipping algorithm in git bisection.

Because RunnableVersion does not indicate whether a specific revision has been skipped, it will choose a random version regardless of its skip status.

Bias was set to better choose an appropriate version to test based on the skipping algorithm in git bisection.

Because RunnableVersion does not indicate whether a specific revision has been skipped,
it will choose a random version regardless of its skip status.
@chan95821 chan95821 requested review from a team and codebytere as code owners March 10, 2025 05:35
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 87.28% (-0.2%) from 87.472%
when pulling d73e56a on chan95821:bisect-skip
into 72117c8 on electron:main.

@erickzhao erickzhao changed the title feat: add skip feature for bisection(#950) feat: add skip feature for bisection Mar 10, 2025
@erickzhao erickzhao self-requested a review March 19, 2025 18:44
@codebytere codebytere requested a review from dsanders11 July 22, 2025 09:47

@dsanders11 dsanders11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @chan95821!

@dsanders11 dsanders11 merged commit 7e58cbe into electron:main Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants