test: migrate publish button tests to RTL#1618
Merged
Merged
Conversation
dsanders11
approved these changes
Jul 30, 2024
Member
I think this is reasonable. Migrating off of Enzyme will unblock us on other stuff and long-term we can further improve our testing methodology. |
erickzhao
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1408.
I'm also adding a helper function that allows us to access class components' instances, since RTL doesn't expose them and a bunch of our tests are messing with component internals directly; that's probably something we should move away from at some point, but for now that helper should make it a bit easier to migrate away from Enzyme.