test: use RTL in the version selector tests#1435
Merged
Merged
Conversation
VerteDinde
reviewed
Aug 23, 2023
93cd467 to
f3fb27f
Compare
erickzhao
approved these changes
Nov 2, 2023
Member
|
Looks like this was approved a a couple of months ago but not merged. @erikian is this PR still something that should be merged; and if so, could you update the PR to resolve the conflicts that have built up in the interim? 😸 |
Member
Author
|
@ckerr I'll try to get this PR rebased later this week, thanks for the reminder! |
5a2fdfa to
6e1e079
Compare
6e1e079 to
e667281
Compare
da4f64c to
708e7fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step towards #1408. I've added a couple of changes on top of just migrating the tests to RTL (open to feedback if any of them are a bad idea):
VersionSelectcomponent - I didn't do it in abeforeEachblock because we only need to render the whole component in one testrenderVersionContextMenucomponentI've also included thetestMatchchange from #1434 just so the RTL tests will run on CI for this PR. This means that #1434 should land first to keep things separate and to prevent it from becoming an empty changeset.