chore: remove dead task runner code (#1938)

Author: dsanders11

src/ambient.d.ts

@@ -1,7 +1,6 @@
 import type * as MonacoType from 'monaco-editor';
 
 import {
-  BisectRequest,
   BlockableAccelerator,
   DownloadVersionParams,
   EditorValues,
@@ -13,17 +12,14 @@ import {
   InstallStateEvent,
   MessageOptions,
   NodeTypes,
-  OutputEntry,
   PMOperationOptions,
   PackageJsonOptions,
   ProgressObject,
   ReleaseInfo,
-  RunResult,
   RunnableVersion,
   SelectedLocalVersion,
   SemVer,
   StartFiddleParams,
-  TestRequest,
   Version,
 } from './interfaces';
 import { App } from './renderer/app';
@@ -39,11 +35,6 @@ declare global {
         listener: () => void,
         options?: { signal: AbortSignal },
       ): void;
-      addEventListener(
-        type: 'bisect-task',
-        listener: (request: BisectRequest) => void,
-        options?: { signal: AbortSignal },
-      ): void;
       addEventListener(
         type: 'execute-monaco-command',
         listener: (commandId: string, opts?: Partial<{ all: boolean }>) => void,
@@ -78,11 +69,6 @@ declare global {
         type: 'saved-local-fiddle',
         listener: (filePath: string) => void,
       ): void;
-      addEventListener(
-        type: 'test-task',
-        listener: (request: TestRequest) => void,
-        options?: { signal: AbortSignal },
-      ): void;
       addEventListener(
         type: 'toggle-monaco-option',
         listener: (path: string) => void,
@@ -157,7 +143,6 @@ declare global {
         command: string,
       ): Promise<string>;
       platform: string;
-      pushOutputEntry(entry: OutputEntry): void;
       readThemeFile(name: string): Promise<LoadedFiddleTheme | null>;
       reloadWindows(): void;
       removeAllListeners(type: FiddleEvent): void;
@@ -171,7 +156,6 @@ declare global {
       showWindow(): void;
       startFiddle(params: StartFiddleParams): Promise<void>;
       stopFiddle(): void;
-      taskDone(result: RunResult): void;
       themePath: string;
       uncacheTypes(ver: RunnableVersion): Promise<void>;
       unwatchElectronTypes(): Promise<void>;

src/interfaces.ts

@@ -89,16 +89,6 @@ export interface SetupRequest {
   useObsolete?: boolean;
 }
 
-export interface BisectRequest {
-  setup: SetupRequest;
-  goodVersion: string;
-  badVersion: string;
-}
-
-export interface TestRequest {
-  setup: SetupRequest;
-}
-
 export interface OutputEntry {
   text: string;
   timeString: string;
@@ -175,7 +165,6 @@ export interface SelectedLocalVersion {
 
 export type FiddleEvent =
   | 'before-quit'
-  | 'bisect-task'
   | 'clear-console'
   | 'electron-types-changed'
   | 'execute-monaco-command'
@@ -197,7 +186,6 @@ export type FiddleEvent =
   | 'select-all-in-editor'
   | 'set-show-me-template'
   | 'show-welcome-tour'
-  | 'test-task'
   | 'toggle-bisect'
   | 'toggle-monaco-option'
   | 'undo-in-editor'

src/ipc-events.ts

@@ -26,10 +26,6 @@ export enum IpcEvents {
   BLOCK_ACCELERATORS = 'BLOCK_ACCELERATORS',
   SET_SHOW_ME_TEMPLATE = 'SET_SHOW_ME_TEMPLATE',
   CLICK_TITLEBAR_MAC = 'CLICK_TITLEBAR_MAC',
-  TASK_BISECT = 'TASK_BISECT',
-  TASK_TEST = 'TASK_TEST',
-  TASK_DONE = 'TASK_DONE',
-  OUTPUT_ENTRY = 'OUTPUT_ENTRY',
   RELOAD_WINDOW = 'RELOAD_WINDOW',
   SET_NATIVE_THEME = 'SET_NATIVE_THEME',
   SHOW_WINDOW = 'SHOW_WINDOW',
@@ -94,8 +90,6 @@ export const ipcMainEvents = [
   IpcEvents.SET_SHOW_ME_TEMPLATE,
   IpcEvents.BLOCK_ACCELERATORS,
   IpcEvents.CLICK_TITLEBAR_MAC,
-  IpcEvents.OUTPUT_ENTRY,
-  IpcEvents.TASK_DONE,
   IpcEvents.RELOAD_WINDOW,
   IpcEvents.SET_NATIVE_THEME,
   IpcEvents.SHOW_WINDOW,

src/preload/preload.ts

@@ -9,10 +9,8 @@ import {
   Files,
   IPackageManager,
   MessageOptions,
-  OutputEntry,
   PMOperationOptions,
   PackageJsonOptions,
-  RunResult,
   RunnableVersion,
   StartFiddleParams,
   Version,
@@ -22,7 +20,6 @@ import { FiddleTheme } from '../themes-defaults';
 
 const channelMapping: Record<FiddleEvent, IpcEvents> = {
   'before-quit': IpcEvents.BEFORE_QUIT,
-  'bisect-task': IpcEvents.TASK_BISECT,
   'clear-console': IpcEvents.CLEAR_CONSOLE,
   'electron-types-changed': IpcEvents.ELECTRON_TYPES_CHANGED,
   'execute-monaco-command': IpcEvents.MONACO_EXECUTE_COMMAND,
@@ -44,7 +41,6 @@ const channelMapping: Record<FiddleEvent, IpcEvents> = {
   'select-all-in-editor': IpcEvents.SELECT_ALL_IN_EDITOR,
   'set-show-me-template': IpcEvents.SET_SHOW_ME_TEMPLATE,
   'show-welcome-tour': IpcEvents.SHOW_WELCOME_TOUR,
-  'test-task': IpcEvents.TASK_TEST,
   'toggle-bisect': IpcEvents.BISECT_COMMANDS_TOGGLE,
   'toggle-monaco-option': IpcEvents.MONACO_TOGGLE_OPTION,
   'undo-in-editor': IpcEvents.UNDO_IN_EDITOR,
@@ -205,9 +201,6 @@ export async function setupFiddleGlobal() {
       );
     },
     platform: process.platform,
-    pushOutputEntry(entry: OutputEntry) {
-      ipcRenderer.send(IpcEvents.OUTPUT_ENTRY, entry);
-    },
     reloadWindows() {
       ipcRenderer.send(IpcEvents.RELOAD_WINDOW);
     },
@@ -252,9 +245,6 @@ export async function setupFiddleGlobal() {
     stopFiddle() {
       ipcRenderer.send(IpcEvents.STOP_FIDDLE);
     },
-    taskDone(result: RunResult) {
-      ipcRenderer.send(IpcEvents.TASK_DONE, result);
-    },
     themePath: await ipcRenderer.sendSync(IpcEvents.GET_THEME_PATH),
     async uncacheTypes(ver: RunnableVersion) {
       await ipcRenderer.invoke(IpcEvents.UNCACHE_TYPES, ver);

src/renderer/app.tsx

@@ -6,7 +6,6 @@ import { FileManager } from './file-manager';
 import { RemoteLoader } from './remote-loader';
 import { Runner } from './runner';
 import { AppState } from './state';
-import { TaskRunner } from './task-runner';
 import { activateTheme, getCurrentTheme, getTheme } from './themes';
 import { getPackageJson } from './utils/get-package';
 import {
@@ -34,7 +33,6 @@ export class App {
   public fileManager: FileManager;
   public remoteLoader: RemoteLoader;
   public runner: Runner;
-  public readonly taskRunner: TaskRunner;
   public readonly electronTypes: ElectronTypes;
 
   constructor() {
@@ -46,8 +44,6 @@ export class App {
     this.runner = new Runner(this.state);
     this.getEditorValues = this.getEditorValues.bind(this);
 
-    this.taskRunner = new TaskRunner(this);
-
     this.electronTypes = new ElectronTypes(window.monaco);
   }
 

src/renderer/state.ts

@@ -1094,7 +1094,6 @@ export class AppState {
       text: strData.trim(),
       timeString: this.timeFmt.format(new Date()),
     };
-    window.ElectronFiddle.pushOutputEntry(entry);
     this.output.push(entry);
   }
 

src/renderer/task-runner.ts

@@ -20,5 +20,4 @@ export class AppMock {
   public runner = new RunnerMock();
   public setup = vi.fn();
   public state = new StateMock();
-  public taskRunner = {};
 }

tests/mocks/app.ts

@@ -37,7 +37,6 @@ export class ElectronFiddleMock {
   public openThemeFolder = vi.fn();
   public packageRun = vi.fn();
   public platform = process.platform;
-  public pushOutputEntry = vi.fn();
   public reloadWindows = vi.fn();
   public removeAllListeners = vi.fn();
   public removeVersion = vi.fn();
@@ -50,7 +49,6 @@ export class ElectronFiddleMock {
   public showWindow = vi.fn();
   public startFiddle = vi.fn();
   public stopFiddle = vi.fn();
-  public taskDone = vi.fn();
   public readThemeFile = vi.fn();
   public themePath = '~/.electron-fiddle/themes';
   public uncacheTypes = vi.fn();