refactor: use more production code, fewer mocks in github tests (#1943)

* refactor: extract GIST_MAX_FILE_SIZE / GIST_MAX_FILE_COUNT constants

Hoist the gist size/count limits out of `src/main/github.ts` into `src/constants.ts` so tests can reference them by name instead of duplicating the magic numbers.

* refactor: STATIC_DIR in main/constants.ts now works in both production and tests

* test: add electron app.setPath() mock

* refactor: reduce scope of MOCK_GIST_FILES, MOCK_GIST_DATA

* refactor: remove magic string from github.spec.ts

* test: use more production code, fewer mocks in github.spec.ts

* test: stop mocking getTemplate() in github.spec.ts

* refactor: minor copyediting

* Apply suggestion from @dsanders11

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

* test: safeguard tests against the credentials file location changing

* fixup! Apply suggestion from @dsanders11

* fix: unused variable warning

* fixup! test: safeguard tests against the credentials file location changing

fix: oops, removed a line accidentally

---------

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>

Author: ckerr

src/constants.ts

@@ -2,3 +2,8 @@ export const SENTRY_DSN =
   'https://966a5b01ac8d4941b81e4ebd0ab4c991@sentry.io/1882540';
 
 export const ELECTRON_DTS = 'electron.d.ts';
+
+// These are the limits GitHub enforces for gist sizes.
+// We use these to fail fast locally when creating/updating a new gist.
+export const GIST_MAX_FILE_SIZE = 10 * 1024 * 1024; // 10 MB per file
+export const GIST_MAX_FILE_COUNT = 300;

src/main/constants.ts

@@ -2,7 +2,15 @@ import * as path from 'node:path';
 
 import { app } from 'electron';
 
-export const STATIC_DIR = path.resolve(__dirname, '../static');
+// Find the root dir for static assets (eg `show-me/`, `electron-quick-start/`).
+// In production, the bundled main script lives in `.webpack/main/` and webpack
+// copies static assets to `.webpack/static/`.
+// In tests (vitest loads the source TypeScript directly), `__dirname` is
+// `src/main/` and the static folder lives at the repository root.
+export const STATIC_DIR = path.resolve(
+  __dirname,
+  process.env.VITEST ? '../../static' : '../static',
+);
 
 export const ELECTRON_DOWNLOAD_PATH = path.join(
   app.getPath('userData'),

src/main/github.ts

@@ -6,6 +6,7 @@ import { IpcMainInvokeEvent, app, safeStorage } from 'electron';
 
 import { getTemplate } from './content';
 import { ipcMainManager } from './ipc';
+import { GIST_MAX_FILE_COUNT, GIST_MAX_FILE_SIZE } from '../constants';
 import { EditorValues, GistLoadResult, GistRevision } from '../interfaces';
 import { IpcEvents } from '../ipc-events';
 import { isSupportedFile } from '../utils/editor-utils';
@@ -25,10 +26,6 @@ const SHA_PATTERN = /^[0-9a-f]{40}$/;
 
 const MAX_DESCRIPTION_LENGTH = 256;
 
-const MAX_FILE_SIZE = 10 * 1024 * 1024; // 10 MB per file — GitHub's gist limit
-
-const MAX_FILE_COUNT = 300; // GitHub's gist file limit
-
 function isValidToken(token: unknown): token is string {
   return typeof token === 'string' && TOKEN_PATTERN.test(token);
 }
@@ -62,7 +59,8 @@ function areValidGistFiles(
 
   const entries = Object.entries(files as Record<string, unknown>);
 
-  if (entries.length === 0 || entries.length > MAX_FILE_COUNT) return false;
+  if (entries.length === 0 || entries.length > GIST_MAX_FILE_COUNT)
+    return false;
 
   for (const [key, value] of entries) {
     // null entries are used to delete files during update
@@ -75,7 +73,7 @@ function areValidGistFiles(
     if (filename.length === 0) return false;
     if (filename !== key) return false;
     if (typeof content !== 'string') return false;
-    if (content.length > MAX_FILE_SIZE) return false;
+    if (content.length > GIST_MAX_FILE_SIZE) return false;
   }
 
   return true;
@@ -437,6 +435,7 @@ export function setupGitHub() {
 // Exported for testing
 export const testing = {
   fetchExample,
+  getCredentialsPath,
   handleGistCreate,
   handleGistDelete,
   handleGistListCommits,
@@ -445,4 +444,6 @@ export const testing = {
   handleTokenCheckAuth,
   handleTokenSignIn,
   handleTokenSignOut,
+  loadToken,
+  saveToken,
 };

tests/main/content.spec.ts

@@ -20,9 +20,6 @@ import { getTemplate, getTestTemplate } from '../../src/main/content';
 import { isReleasedMajor } from '../../src/main/versions';
 
 vi.unmock('fs-extra');
-vi.mock('../../src/main/constants', () => ({
-  STATIC_DIR: path.join(__dirname, '../../static'),
-}));
 vi.mock('../../src/main/versions', () => ({
   isReleasedMajor: vi.fn(),
 }));