Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new WebAssembly API support in Node.js #36420

Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix: new WebAssembly API support in Node.js #36420

merged 1 commit into from
Dec 5, 2022

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 21, 2022 •
edited
Loading

Description of Change

Closes #36282.

Re-enables support for WebAssembly.{compileStreaming|instantiateStreaming} in Node.js. We need to reconfigure initialization order a bit here for reasons stated in #36282 as gin conflicts with how Node.js controls isolate initialization.

Checklist

Release Notes

Notes: Enabled support for WebAssembly.{compileStreaming|instantiateStreaming} in Node.js.

@codebytere codebytere added semver/patch backwards-compatible bug fixes no-backport labels Nov 21, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 21, 2022
@codebytere codebytere marked this pull request as draft November 22, 2022 11:59
@codebytere codebytere marked this pull request as ready for review November 22, 2022 14:04
@codebytere codebytere marked this pull request as draft November 22, 2022 16:53
@codebytere codebytere marked this pull request as ready for review November 22, 2022 21:50
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2022
nornagon
nornagon approved these changes Nov 28, 2022
View reviewed changes
shell/app/node_main.cc Show resolved Hide resolved
@jkleinsc jkleinsc merged commit b90a5ba into main Dec 5, 2022
@jkleinsc jkleinsc deleted the fix-wasm branch December 5, 2022 17:07
@release-clerk
Copy link

release-clerk bot commented Dec 5, 2022

Release Notes Persisted

Enabled support for WebAssembly.{compileStreaming|instantiateStreaming} in Node.js.

@Soltus Soltus mentioned this pull request Feb 16, 2023
Closed
khalwa pushed a commit to solarwindscloud/electron that referenced this pull request Feb 22, 2023
@codebytere @khalwa
fix: new WebAssembly API support in Node.js (electron#36420)
af85dd7
@commit-lint commit-lint bot mentioned this pull request Mar 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr left review comments

@VerteDinde VerteDinde VerteDinde approved these changes

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable WebAssembly.{compileStreaming|instantiateStreaming} in Node.js
5 participants
@codebytere @ckerr @nornagon @VerteDinde @jkleinsc