chore: bump node to v16.17.0 (main) by electron-roller[bot] · Pull Request #35350 · electron/electron

electron-roller · 2022-08-16T13:00:42Z

Updating Node.js to v16.17.0.

Notes: Updated Node.js to v16.17.0.

* docs: Update Quick Start Guide for Electron 12 With `contextIsolation` enabled by default in Electron 12, the Getting Started Guide no longer works as it is written. In order for the basic example to display values from `process.versions`, we need to add a `preload.js` to the example. * fix: annotate preload code block with a language * docs: update quick-start Fiddle example to use preload to provide version info * fix: ensure example files end in a newline * docs: add security warning to instructions for turning off contextIsolation Co-authored-by: John Kleinschmidt <jkleinsc@github.com> * docs: treat preload as an adjective instead of a noun Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093

patches/node/fix_revert_include_order_of_node_http2_header.patch

The "node_http2.h" include reordering enforced by clang-format (nodejs@32446d8#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771cR1) broke Electron's Node.js upgrade on Windows. ```sh In file included from ../../third_party/electron_node/src/node_http2.cc:1: In file included from ../../third_party/electron_node/src/node_http2.h:8: ../../third_party/electron_node/deps/nghttp2/lib/includes\nghttp2/nghttp2.h(930,9): error: unknown type name 'ssize_t' typedef ssize_t (*nghttp2_data_source_read_callback)( ^ ``` ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to typedef it on Windows like in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to typedef it on Windows like in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

nodejs/node#42539

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to typedef it on Windows like in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

rzhao271

Just some clarification questions

rzhao271 · 2022-08-25T21:24:38Z

patches/node/fix_handle_boringssl_and_openssl_incompatibilities.patch

+ #include "util.h"
+
+-#if HAVE_OPENSSL
+#if 0


I noticed the other #ifs got && !defined(OPENSSL_IS_BORINGSSL) added. Should this one also have it added?

no - that doesn't work in this context unfortunately. I tried that initially.

patches/node/support_v8_sandboxed_pointers.patch

lib/asar/fs-wrapper.ts

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>

nodejs/node#44393

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

RaisinTen

LGTM

release-clerk · 2022-08-29T13:55:39Z

Release Notes Persisted

Updated Node.js to v16.17.0.

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

The "node_http2.h" include reordering enforced by clang-format broke Electron's Node.js upgrade on Windows. ssize_t is a part of the POSIX standard and it's not available on Windows, so the fix for this is to include "node.h" which typedefs it on Windows in https://github.com/nodejs/node/blob/bb4dff783ddb3b20c67041f7ccef796c335c2407/src/node.h#L212-L220. Refs: electron/electron#35350 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#44393 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>

* chore: bump node in DEPS to v16.17.0 * chore: fixup asar patch * lib: use null-prototype objects for property descriptors nodejs/node#43270 * src: make SecureContext fields private nodejs/node#43173 * crypto: remove Node.js-specific webcrypto extensions nodejs/node#43310 * test: refactor to top-level await nodejs/node#43500 * deps: cherry-pick two libuv fixes nodejs/node#43950 * src: slim down env-inl.h nodejs/node#43745 * util: add AggregateError.prototype.errors to inspect output nodejs/node#43646 * esm: improve performance & tidy tests nodejs/node#43784 * src: NodeArrayBufferAllocator delegates to v8's allocator nodejs/node#43594 * chore: update patch indices * chore: update filenames * src: refactor IsSupportedAuthenticatedMode nodejs/node#42368 * src: add --openssl-legacy-provider option nodejs/node#40478 * lib,src: add source map support for global eval nodejs/node#43428 * trace_events: trace net connect event nodejs/node#43903 * deps: update ICU to 71.1 nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093 * lib: give names to promisified exists() and question() nodejs/node#43218 * crypto: add CFRG curves to Web Crypto API nodejs/node#42507 * src: fix memory leak for v8.serialize nodejs/node#42695 This test does not work for Electron as they do not use V8's ArrayBufferAllocator. * buffer: fix atob input validation nodejs/node#42539 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

electron-roller bot requested a review from a team as a code owner August 16, 2022 13:00

electron-roller bot added no-backport semver/patch backwards-compatible bug fixes labels Aug 16, 2022

electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Aug 16, 2022

codebytere self-assigned this Aug 22, 2022

codebytere requested a review from a team as a code owner August 22, 2022 19:18

codebytere force-pushed the roller/node/main branch 4 times, most recently from 2319577 to 96c491a Compare August 25, 2022 08:48

electron-roller bot and others added 18 commits August 25, 2022 14:12

chore: bump node in DEPS to v16.17.0

241b207

chore: fixup asar patch

61e7fad

lib: use null-prototype objects for property descriptors

30c7840

nodejs/node#43270

src: make SecureContext fields private

9aa457e

nodejs/node#43173

crypto: remove Node.js-specific webcrypto extensions

9828218

nodejs/node#43310

test: refactor to top-level await

2dae231

nodejs/node#43500

deps: cherry-pick two libuv fixes

d90f914

nodejs/node#43950

src: slim down env-inl.h

cd8b004

nodejs/node#43745

util: add AggregateError.prototype.errors to inspect output

9afd11e

nodejs/node#43646

esm: improve performance & tidy tests

e1bbdd2

nodejs/node#43784

src: NodeArrayBufferAllocator delegates to v8's allocator

734423c

nodejs/node#43594

chore: update patch indices

f4ca633

chore: update filenames

f7a5006

src: refactor IsSupportedAuthenticatedMode

109a027

nodejs/node#42368

src: add --openssl-legacy-provider option

6a969f5

nodejs/node#40478

lib,src: add source map support for global eval

1476ff6

nodejs/node#43428

trace_events: trace net connect event

28089cd

nodejs/node#43903

deps: update ICU to 71.1

18d73b9

nodejs/node#42655 This fails the test because it's missing https://chromium-review.googlesource.com/c/chromium/deps/icu/+/3841093

codebytere force-pushed the roller/node/main branch from 96c491a to f70ba42 Compare August 25, 2022 12:13

codebytere reviewed Aug 25, 2022

View reviewed changes

patches/node/fix_revert_include_order_of_node_http2_header.patch Outdated Show resolved Hide resolved

RaisinTen mentioned this pull request Aug 25, 2022

src: fix ssize_t error from nghttp2.h nodejs/node#44393

Merged

buffer: fix atob input validation

ed65e52

nodejs/node#42539

codebytere force-pushed the roller/node/main branch from a945f75 to 79cabe0 Compare August 25, 2022 13:00

rzhao271 reviewed Aug 25, 2022

View reviewed changes

src: fix ssize_t error from nghttp2.h

0f89c67

nodejs/node#44393

codebytere force-pushed the roller/node/main branch from 79cabe0 to 0f89c67 Compare August 29, 2022 07:42

codebytere requested a review from RaisinTen August 29, 2022 10:24

RaisinTen approved these changes Aug 29, 2022

View reviewed changes

jkleinsc approved these changes Aug 29, 2022

View reviewed changes

jkleinsc merged commit d0e220c into main Aug 29, 2022

jkleinsc deleted the roller/node/main branch August 29, 2022 13:55

rekmarks mentioned this pull request Sep 14, 2022

[Question]: Will Electron@21 use Node.js ^16.17.0? #35675

Closed

commit-lint bot mentioned this pull request Nov 22, 2022

[pull] main from electron:main Blaquez-home/electron#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump node to v16.17.0 (main)#35350

chore: bump node to v16.17.0 (main)#35350
jkleinsc merged 23 commits intomainfrom
roller/node/main

electron-roller bot commented Aug 16, 2022

Uh oh!

Uh oh!

rzhao271 left a comment

Uh oh!

rzhao271 Aug 25, 2022

Uh oh!

codebytere Aug 29, 2022

Uh oh!

Uh oh!

Uh oh!

RaisinTen left a comment

Uh oh!

release-clerk bot commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

electron-roller bot commented Aug 16, 2022

Uh oh!

Uh oh!

rzhao271 left a comment

Choose a reason for hiding this comment

Uh oh!

rzhao271 Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

codebytere Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RaisinTen left a comment

Choose a reason for hiding this comment

Uh oh!

release-clerk bot commented Aug 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants