Skip to content

feat: read process fields (#14) #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 1, 2019
Merged

feat: read process fields (#14) #17

merged 3 commits into from
Dec 1, 2019

Conversation

tong
Copy link
Contributor

@tong tong commented Dec 1, 2019

read process fields correctly.

MarshallOfSound
MarshallOfSound requested changes Dec 1, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you push again so that CI runs, I just enabled it for forked PRs

MarshallOfSound
MarshallOfSound requested changes Dec 1, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can you extract this to the markdown-helpers file and add a set of tests for it. (Process tags not present, just renderer, just main, both, etc.)

Once we've got tests I'll land and release this 👍

@tong
improve read process fields.
416b87e 
* add ProcessBlock type
* add markdown-helper.findProcess
* add markdown-helper.findProcess tests
@MarshallOfSound MarshallOfSound changed the title read process fields (#14) feat: read process fields (#14) Dec 1, 2019
@MarshallOfSound MarshallOfSound merged commit d2e86df into electron:master Dec 1, 2019
@electron-bot
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarshallOfSound MarshallOfSound mentioned this pull request Dec 1, 2019
Closed
@tong
Copy link
Contributor Author

tong commented Dec 1, 2019

Thanks!

@tong tong deleted the read-process-fields branch December 1, 2019 22:27
@tong tong mentioned this pull request Dec 2, 2019
Closed
@tong
Copy link
Contributor Author

tong commented Mar 10, 2020

Seriously, why isn't this used for the electron builds?
Delivering faulty api description since 2 major releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tong @electron-bot @MarshallOfSound