chore: use prettier for lint #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhashimotoo
changed the title
vhashimotoo
force-pushed
the
use-prettier
branch
from
83d5ddf
to
0fd92b8
Compare
vhashimotoo
changed the title
erickzhao
reviewed
Mar 25, 2020
malept
requested changes
Mar 25, 2020
Comment on lines
+19
to
+20
| npm ci | ||
| npm test |
There was a problem hiding this comment.
Maybe for another PR, but generally I've put npm ci and npm test in different run steps, but if you want to do it in one step:
Suggested change
| npm ci | |
| npm test | |
| npm install-ci-test |
Comment on lines
+11
to
+18
| if: github['ref'] == 'refs/heads/master' | ||
| - name: Use Node.js 10.x | ||
| if: github['ref'] == 'refs/heads/master' | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 10.x | ||
| - name: npm install, build, and test | ||
| if: github['ref'] == 'refs/heads/master' |
There was a problem hiding this comment.
Again, maybe for another PR, but shouldn't the branch check be on the on: push instead of on each step?
on:
push:
branches:
- master
|
It's pretty old config and I plan to update them to standard web infra config in refactor PR. Added EDIT: Also we maybe need a request update the required checks. |
malept
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
Also enabled lint for
yamlfiles so every app is similar to others.