Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Missing documentation for how to use assets #116

Open
robinwassen opened this issue Mar 5, 2019 · 2 comments
Open

docs: Missing documentation for how to use assets #116

robinwassen opened this issue Mar 5, 2019 · 2 comments

Comments

@robinwassen
Copy link

The argument assets to specify the assets path is mentioned in the docs - but no instructions on what files the folder expected to contain.

There is a folder called template/assets with four different sample electron icons named SampleAppx.*.png. But it feels counterintuitive to create an asset folder for your app and name the icons SampleAppx.

Some kind of instructions with more details on how to use assets would be a great addition. 👍

@robinwassen
Copy link
Author

Gave it a try - it worked to copy the template/assets folder, modify the icons and specify the path. Still could use some docs though.

@jameshfisher
Copy link

Indeed, the template has these "SampleAppx" filenames hard-coded ... https://github.com/felixrieseberg/electron-windows-store/blob/master/template/appxmanifest.xml#L30-L31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants