Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Dictionary #36

Open
Camyll opened this issue Jan 5, 2017 · 11 comments
Open

Add to Dictionary #36

Camyll opened this issue Jan 5, 2017 · 11 comments

Comments

@Camyll
Copy link

Camyll commented Jan 5, 2017

Why is it that add to dictionary is only enabled on macs? Also, even if I try and add to dictionary on my mac, it doesn't do anything.

@alexbrazier
Copy link

I'm having the same issue. This error is thrown:

Error: Could not call remote function 'replaceMisspelling'. Check that the function signature is correct. Underlying error: Error processing argument at index 0, conversion failure from undefined
    at callFunction 

@clusterberries
Copy link

The same question... Actually method spellCheckHandler.addToDictionary(text) can be replaced with
spellCheckHandler.currentSpellchecker.add(text), and it works for Windows. But new word is saved only for current application session. After reload the word is missing and highlighted.

@Nantris
Copy link

Nantris commented Apr 27, 2017

@clusterberries So theoretically you could save an array of the added words and re-add them at the beginning each session?

@Nantris
Copy link

Nantris commented Apr 27, 2017

If you're doing this (with or without saving across sessions) and could share a snippet of code showing how to implement as simple as it sounds, I would be most appreciative.

@clusterberries
Copy link

@slapbox I've stopped working on it for now. But it should not be difficult, you can save all added words in local storage or somewhere else. When the app is initializing, call spellCheckHandler.currentSpellchecker.add() for every word retrieved from local storage.

@mediaslav
Copy link

@clusterberries looks like I owe you 🍻 for this simple idea

@rharish100193
Copy link

I am having the same issue. On Clicking Add to Dictionary option, electron-spellchecker is throwing the following error.

ectron.asar/renderer/ap…:234 
Uncaught (in promise) Error: Could not call remote function 'replaceMisspelling'. 
Check that the function signature is correct. 

Underlying error: Error processing argument at index 0, conversion failure from undefined

Error: Could not call remote function 'replaceMisspelling'. 
Check that the function signature is correct. 

Underlying error: Error processing argument at index 0, conversion failure from undefined

Has anyone solved this issue ?? Is there any way to override the addToDictionary Method ??

@rharish100193
Copy link

A guy has written a fix for this already and it is still pending in the Pull request. As a workaround, we can use

info.selection = info.selectionText

@iamgabrielma
Copy link

Would be great to see this in Windows as well, Simplenote uses this in order to spell check and only OSX users can benefit from this feature.

Adding here two internal references to reach out users that have requested or asked about this: 1507139-zen , 1768586-zen

@KWaldt
Copy link

KWaldt commented Jan 5, 2020

Years later, and it still seems to be an issue. Is there a valid workaround for this? I tried spellCheckHandler.currentSpellchecker.add(), but it seems that spellCheckHandler.currentSpellchecker always returns null for some reason. (I found a user that had the same issue, but the solution in the threat didn't work for me.)
(You know, considering a big application like Notion.so doesn't have that feature yet, it makes me think that it might not be a trivial fix.)

Of course, if it was intergated officially, it would be even better. Adding custom words is a basic feature, and it's especially weird that Mac has it and Windows doesn't.

@ccope
Copy link

ccope commented May 12, 2022

I'm very surprised that Chrome and Electron fetch a dictionary from the internet rather than using the dictionaries in the native OS. It is quite annoying to have to update dictionaries for specific applications, if they even support it. I don't see a way to switch dictionaries or add entries at all in the Electron apps I use on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants