Stop process if already running

[demetris-manikas]

If the application is already running the installation fails so just kill it.
Maybe it would be a better solution to show some info and drop the installation but my knowledge about NSIS is still quite limited so as to implement this kind of behavior.

[mention-bot]

By analyzing the blame information on this pull request, we identified @stefanjudis to be a potential reviewer

[stefanjudis]

Is it possible to include a button on a dialog in case the user has something going before killing the running app?

That sounds great!!! 👍

[demetris-manikas]

Any comments on changed implementation?

[stefanjudis]

Damn it. Sorry - I'll try to have a look at it tonight. :)

[stefanjudis]

@demetris-manikas Just tried it and it looks good to me.

Only thing:

Can we make the dialog a bit more explanatory?

I'm thinking of something like.

"App is already running. This may affect the installation process. Please close the application."

And I think the cta's could be better.

Also it'd be great if "ignore" could be "close & continue" showing, that this will shut down the application.

What do you think?

[mkaz]

The solution I ended up going with was a two button OK / CANCEL Message box.
Here's that code I used:

MessageBox MB_OKCANCEL|MB_ICONEXCLAMATION "${APP_NAME} is running. $\r$\nClick OK to close it and continue with install" /SD IDCANCEL IDOK doStopProcess
        Abort
    doStopProcess:
         DetailPrint "Closing running ${APP_NAME} ..."
         ${nsProcess::KillProcess} "${APP_NAME}.exe" $R0
         DetailPrint "Waiting for ${APP_NAME} to close."
         Sleep 2000

The result looks like:

[stefanjudis]

@mkaz @demetris-manikas

I have to say - I actually like @mkaz 's version more.

What do you two think?

[demetris-manikas]

It 's fine by me. I only wanted the installer not to hang when the app is already running.
Your call.

[demetris-manikas]

Incorporated changes proposed by mkaz.

[stefanjudis]

👍 Looks good to me thanks!