File association on windows

[vQuagliaro]

No description provided.

[mention-bot]

By analyzing the blame information on this pull request, we identified @stefanjudis, @demetris-manikas and @vxsx to be potential reviewers

[TristanPouliquen]

It should still work if the custom template is based on the original one

[vQuagliaro]

Hi @stefanjudis, @demetris-manikas and @vxsx,
In the PR, a new option is created to define a custom file association on Windows.
Thank in advance for reviewing and leaving comments.

[stefanjudis]

@vQuagliaro sorry for delay.

I'm currently on vacation but will be back tomorrow. So I'm trying to get to it asap.
If nothing happened in 2day - feel free to ping again.

[sergeysova]

Very good!

[vQuagliaro]

Hi @stefanjudis,
I'm back 😄 !
Thank in advance for reviewing and leaving comments.

[stefanjudis]

@vQuagliaro

Hey hey, I finally had some time to look at it. Sorry again for the delay.

a custom file association on Windows.

Can you explain me the use case for this. I'm not familiar with this file association thing. :(

[TristanPouliquen]

@stefanjudis I worked with Vincent on a project with Electron.

File association in Windows is the feature that allows you to tell Windows that a .myapp file type is to be opened with your Electron application.

Then, when the user double-clicks on the files with your custom file type, it opens them automatically with your application.

Here is a blog article we wrote on this feature to explain it in more detail: http://www.theodo.fr/blog/2015/12/link-files-to-application-in-windows/

[stefanjudis]

@TristanPouliquen @vQuagliaro

Uhhh nice!!! Thanks for explanation.
I will have a look at it tonight.

What about the macos counterpart. Did you folks play around with that too?

[TristanPouliquen]

@stefanjudis It is on our TODO list. But the mechanism seems to be quite different and it is not in the scope of the project we are working on at work for the moment.

But we are building an electron-boilerplate to help bootstrap complete Electron applications for all platforms so we will come to it !

[stefanjudis]

But the mechanism seems to be quite different and it is not in the scope of the project we are working on at work for the moment.

Fair enough - probably we would need a proper package installer for that. :)

I will check this PR tonight then and probably also ship a new version of electron-builder tonight.

[stefanjudis]

Shi....

I was working through the PR's from top. :(
@vQuagliaro Can you please resolve conflicts.

Sorry.

[vQuagliaro]

@stefanjudis
Conflicts have been resolved and it has just been tested manually.
The same feature for osx is always on our TODO list.

Thanks for all.

[vQuagliaro]

@stefanjudis,
I'm back 😄 !
If you have time, could you please check and merge this PR?

[stefanjudis]

LGTM! 👍

Just a little side note... please check commit messages of the project. ;)
No need for [...] foo here. :)

But thanks for contribution. :)