Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for windows Unistall/DisplayVersion #76

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Added support for windows Unistall/DisplayVersion #76

merged 1 commit into from
Nov 24, 2015

Conversation

demetris-manikas
Copy link
Contributor

Very small patch to allow for version property in the nsi templates.
Let me know what you think.
Cheers

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @stefanjudis and @vxsx to be potential reviewers.

@stefanjudis
Copy link
Contributor

Thanks. :bowtie:

Fine for me - but it's missing the readme mention about that?

Also what happens if version is not defined - is it still working with an empty string then?

@demetris-manikas
Copy link
Contributor Author

Updated the README.md but you probably have to rephrase it.
If version is not defined APP_VERSION is just an empty string

@stefanjudis
Copy link
Contributor

@demetris-manikas
Now that I'm thinking of it defaulting to version in package.json would be nice maybe?

@demetris-manikas
Copy link
Contributor Author

I played with the idea but it needed more effort. Where is the package.json located? In my case it 's not even in the same dir as config.json. So things get complicated. Setting the path to the package.json would be a way. Should that be a global or a win param? These question made me go for the simple solution. Anyway it is very easy to produce a config.json containing the appropriate data.

@stefanjudis
Copy link
Contributor

Okay - I see. Fair enough. :bowtie:

@stefanjudis stefanjudis added this to the v2.3.0 milestone Nov 24, 2015
stefanjudis added a commit that referenced this pull request Nov 24, 2015
Added support for windows  Unistall/DisplayVersion
@stefanjudis stefanjudis merged commit d01fe82 into electron-userland:master Nov 24, 2015
@stefanjudis stefanjudis self-assigned this Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants