Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsi.template update to fix missing desktop icon #65

Merged
merged 1 commit into from
Nov 12, 2015

Conversation

aaronfrost
Copy link

Added some extras to the nsi template. When I added this, the desktop icon of the installed app was the icon that I provide, and not the default Electron icon. Without this, the app installs and the desktop icon is the Electron icon. So, this was a definite upgrade. I tested this on Win7 and Win10.

… icon of the installed app was the icon that I provide, and not the default Electron icon. Without this, the app installs and the desktop icon is the Electron icon. So, this was a definite upgrade. I tested this on Win7 and Win10.
@aaronfrost
Copy link
Author

I tested this on both Win7 and Win10. So, I feel even more confident that it is a good thing.

Without it, I get a desktop icon, but the icon image is that which is provided by default by Electron. When I add it, then the app installs and the desktop icon is one that matches the icon I provide.

I ran that test on both mentioned version of Windows. Thoughts?

@stefanjudis
Copy link
Contributor

No that's fine.

I think I'll merge it tomorrow. :bowtie:

Thank you very much Sir. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants