Update documentation for Windows PATH, fixes #94 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @stefanjudis, @tborychowski and @radibit to be potential reviewers |
|
Heh, cool, thanks. I just had going to add similar lines. |
| @@ -52,6 +52,10 @@ On Ubuntu(-based) Linux distributions, via apt: | |||
| # apt-get install wine nsis -y | |||
| ``` | |||
| On Windows, download the [nullsoft scriptable installer](http://nsis.sourceforge.net/Download) | |||
| You need to included NSIS in your PATH to find `makensis`, set your global enviornment variable or you can set a session variable using: | |||
There was a problem hiding this comment.
You need to included NSIS
Typo: You need to include NSIS, same for enviornment
|
LGTM |
|
👍 |
stefanjudis
added a commit
that referenced
this pull request
Dec 22, 2015
Update documentation for Windows PATH, fixes #94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info on setting Windows path to find
makensis