Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot overwrite installation if the uninstaller.exe is present, have to delete it manually #8340

Open
KyleRicardo opened this issue Jul 16, 2024 · 3 comments
Labels

Comments

@KyleRicardo
Copy link

  • Electron-Builder Version: 25.0.0
  • Node Version: 20.5.0
  • Electron Version: 28.0.0
  • Electron Type (current, beta, nightly): current
  • Target: Windows NSIS

I'm using the latest (next) version of electron-builder to do the test.

I'm using allusers mode to do the installation, when the app is not installed, then the installer runs perfectly without any problem. But when I test the overwrite installation (for the purpose of upgrading my app), it throw the Error XXX Application cannot be closed. Please close it manually and click Retry to continue. I don't think this error message is accurate, because I have not started my app even once. And of course the Retry button cannot solve the problem.

But when I delete the whole %ProgramFiles%\MyApp folder, then the overwrite re-installation can go smoothly. After deeper dig, I found that removing only the Uninstall MyApp.exe can also do the job.

So I wonder what does the installer check before installation, why the presence of the uninstaller.exe prevents the installer do its job. This is not the behavior I expect.

@beyondkmp
Copy link
Collaborator

@KyleRicardo Can you provide a minimal reproducible version of the code?

@KyleRicardo
Copy link
Author

Thanks, I'll see what I can do.

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants