Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI custom APPLICATIONFOLDER param no longer works #7193

Closed
davej opened this issue Oct 18, 2022 · 5 comments
Closed

MSI custom APPLICATIONFOLDER param no longer works #7193

davej opened this issue Oct 18, 2022 · 5 comments

Comments

@davej
Copy link
Contributor

davej commented Oct 18, 2022

  • Electron-Builder Version: 23.5.0 (previous working version was 22.14.13)
  • Node Version: 16.15.1
  • Electron Version: 19.0.4
  • Target: Windows

Previously it was possible to specify a custom install location for MSI by using the following command:

msiexec /i "<MSI Download File>" APPLICATIONFOLDER="<Desired install folder>"

This was useful when combined with unattended installs. This seems to have broken in a recent version of Electron Builder. Any idea what might be going on here? Happy to jump in and PR this if anybody has a few pointers and why it no longer works.

@mmaietta
Copy link
Collaborator

I'm seeing this change in the (very large) diff

-      installationDirectoryWixName: getWindowsInstallationDirName(appInfo, commonOptions.isPerMachine === true),
+      installationDirectoryWixName: getWindowsInstallationDirName(appInfo, commonOptions.isAssisted || commonOptions.isPerMachine === true),

Can you try setting isAssisted: false in your config? I'm not seeing much else in the diff that could impact this. I saw your comment on PR #6550 as well

@aplum
Copy link
Contributor

aplum commented Oct 19, 2022

@davej Do you only need this to work for unattended installs? I just tried with one of my MSIs (built using electron-builder v23.0.0-alpha.0) using /qn and it installed to the custom dir (full command: msiexec /i "C:\path\to\app.msi" APPLICATIONFOLDER="C:\test" /qn). Does adding /qn fix it in your case?

Do you also need the custom APPLICATIONFOLDER to work when using the installer GUI?

@davej
Copy link
Contributor Author

davej commented Oct 19, 2022

@aplum It is a customer who is using the command, not me personally. I'll reach out to them to see if this is for unattended installs. Thanks so much for your help, I'll report back.

@mmaietta: will try your solution if @aplum's suggestion doesn't work.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants